Enable pixman neon optimisations for arm64 builds #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of pixman has fixed support for compiling the neon assembly files with clang. Older android ndks required disabling the integrated assembler to build them but that workaround is no longer required. This also avoids the bug where older ndks didn't pass -march automatically to external assemblers. See: android/ndk#906 (comment)
GCC does not have syntax unified set explicitly, so pixman has to be able to set it.
Some older clang ndk's integrated assemblers have issues still with the arm64 assembly files. We can just continue disabling the integrated assembler there. The assembly is fine with the integrated assembler on versions r20 and above.
tobil4sk
force-pushed
the
feature/pixman-neon
branch
from
65f4549 to
aab5729
Compare
ios still has errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also enables it for armv7 with android ndks r22+